Model panel color buttons show multiple color chooser windows

[goddard@…]

The following bug report has been submitted:
Platform:        Windows-10-10.0.17134
ChimeraX Version: 0.91 (2019-07-20)
Description
Each time I click a model panel color button on Windows it shows a new color browser right on top of the previous color browser.  So if I change colors of a 4 channel light microscopy data set I get 4 color dialogs shown -- pretty annoying.  On Mac this same operation only produces one color dialog.


Log:
UCSF ChimeraX version: 0.91 (2019-07-20)  
© 2016-2019 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  

> open
"C:\\\Users\\\goddard\\\Desktop\\\CD2RFP_MacBlue_B4649_BiTEsA488_ReducedStack.tif"

Opened multichannel map series
CD2RFP_MacBlue_B4649_BiTEsA488_ReducedStack.tif, 4 channels, 74 images per
channel, grid size 388,246,12, pixel 1.06,1.01,4, shown at step 1, values
float32  




OpenGL version: 3.3.0 NVIDIA 398.35
OpenGL renderer: GeForce GTX 1070 with Max-Q Design/PCIe/SSE2
OpenGL vendor: NVIDIA Corporation

[pett]

Pushed what I believe is a fix. Needs testing on Windows.

[goddard@…]

The "fix" doesn't work, still I get a new color chooser for each color button in Model Panel that I press.

Looking at the code change, it only tries to reuse the color chooser when the same color button is pressed repeatedly.  But the bug is when different Model Panel color buttons are pressed -- changing the colors of 4 different models shows 4 different color choosers.  Also the code never set the self._color_dialog attribute -- but even if it gets set that does not solve the problem.  Maybe keeping a single global color chooser is the way to go -- seems that is what macOS does.

[pett]

Well, put in some hackery to try to get this to work. AFAICT, it's okay on Mac. Needs to be taken for a spin on other platforms...