Fit to Segments menu File... Save[..] problems

[Elaine Meng]

In File to Segments,trying to use File menu to save things.

Choosing "File... Save fit map relative to segmented map" gives message "Please select a map to save" even though I've both chosen a fit in the dialog AND chosen a map by selection in the Model Panel.

Choosing "File... Save chosen fit molecules" gives traceback

Traceback (most recent call last):

File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/chimerax/segger/fit_dialog.py", line 1726, in SaveStrucFit

mol = lfits[0][0].mols[0]

TypeError: 'Fit' object does not support indexing

TypeError: 'Fit' object does not support indexing

File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/chimerax/segger/fit_dialog.py", line 1726, in SaveStrucFit
mol = lfits[0][0].mols[0]

[Elaine Meng]

I was trying to test the "Save map..." one because I noticed you changed its text from a "Place map..." entry in Chimera. Now I realize the message meant I was supposed to choose this map from the pulldown menu as the Structure or map to fit, so that part was user error. However, it does not save a file, but rather generates new models. I'm guessing it should have its original text description, "Place map selected map relative to segmented map" not "Save map..."

[Tom Goddard]

Fixed.

I have renamed the Fit to Segments menu entry "Save fit map relative to segmented map" to be "Copy fit map on segmented map grid". This is a better description of what it does. It uses the map chosen in the "Structure or map to fit" menu at the top of the Fit to Segments dialog and resamples it in its current position on a grid aligned with the map being segmented (chosen in the Segment Map panel menu), but with bounds chosen to cover the fit map. It used to also save this to a file, but I removed that code, not sure why it wanted to save it to a fixed file name. The newly made map copy has the name of the map being fit with " resampled" appended. I also made a better error message when an atomic model instead of a map is being fit. This menu only works when a map is being fit.

I fixed the Fit to Segments menu entry Save chosen fit molecules.