Opened 6 years ago

Closed 6 years ago

#2120 closed defect (fixed)

'view' command: 'Objects' object is not iterable

Reported by: tic20@… Owned by: Conrad Huang
Priority: normal Milestone:
Component: General Controls Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

The following bug report has been submitted:
Platform:        Linux-3.10.0-957.12.2.el7.x86_64-x86_64-with-centos-7.6.1810-Core
ChimeraX Version: 0.91 (2019-06-25)
Description
Looks like the view command is broken.

Log:
UCSF ChimeraX version: 0.91 (2019-06-25)  
© 2016-2019 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  

> open /home/tic20/structure_dump/6j91/Refine_2/6j91_refine_2.pdb

Summary of feedback from opening
/home/tic20/structure_dump/6j91/Refine_2/6j91_refine_2.pdb  
---  
warnings | Ignored bad PDB record found on line 1  
REMARK Date 2019-06-21 Time 17:31:24 BST +0100 (1561134684.19 s)  
  
Ignored bad PDB record found on line 2  
REMARK PHENIX refinement  
  
Ignored bad PDB record found on line 4  
REMARK ****************** INPUT FILES AND LABELS
******************************  
  
Ignored bad PDB record found on line 5  
REMARK Reflections:  
  
Ignored bad PDB record found on line 6  
REMARK file name : /home/tic20/structure_dump/6j91/6j91.mtz  
  
50 messages similar to the above omitted  
  
Chain information for 6j91_refine_2.pdb #1  
---  
Chain | Description  
A | No description available  
B | No description available  
  

> view #1

Traceback (most recent call last):  
File "/opt/UCSF/ChimeraX-daily/lib/python3.7/site-
packages/chimerax/cmd_line/tool.py", line 254, in execute  
cmd.run(cmd_text)  
File "/opt/UCSF/ChimeraX-daily/lib/python3.7/site-
packages/chimerax/core/commands/cli.py", line 2641, in run  
result = ci.function(session, **kw_args)  
File "/opt/UCSF/ChimeraX-daily/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 53, in view  
undo = UndoView("view", session, models)  
File "/opt/UCSF/ChimeraX-daily/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 509, in __init__  
self._before = NamedView(v, v.center_of_rotation, models)  
File "/opt/UCSF/ChimeraX-daily/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 184, in __init__  
for m in models:  
TypeError: 'Objects' object is not iterable  
  
TypeError: 'Objects' object is not iterable  
  
File "/opt/UCSF/ChimeraX-daily/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 184, in __init__  
for m in models:  
  
See log for complete Python traceback.  
  




OpenGL version: 3.3.0 NVIDIA 415.27
OpenGL renderer: TITAN Xp/PCIe/SSE2
OpenGL vendor: NVIDIA Corporation

Change History (3)

comment:1 by Eric Pettersen, 6 years ago

Component: UnassignedGeneral Controls
Owner: set to Tom Goddard
Platform: all
Project: ChimeraX
Status: newassigned
Summary: ChimeraX bug report submission'view' command: 'Objects' object is not iterable

comment:2 by Tom Goddard, 6 years ago

Owner: changed from Tom Goddard to Conrad Huang

Some undo code was added a couple days ago that breaks the view command.

comment:3 by Conrad Huang, 6 years ago

Resolution: fixed
Status: assignedclosed

Fixed in bf9fe95e2.

Undo code got too clever and tried to save only models that will be affected. And got it wrong.

Note: See TracTickets for help on using tickets.