Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#196 closed defect (fixed)

"save" usage shows unusable "quality" option

Reported by: Elaine Meng Owned by: Greg Couch
Priority: blocker Milestone:
Component: Graphics Version:
Keywords: Cc: Tom Goddard
Blocked By: Blocking:
Notify when closed: Platform: all
Project: chimera

Description

"usage save" shows a "quality" option. I thought I heard somebody mention that it applies to JPEG, but no matter what format I save, using "quality" gives a traceback. Example below.

If it's not implemented it shouldn't be shown in the usage. If it is or becomes implemented, please let me know the range of possible values and what the default value is.

save ~/Desktop/junk.jpg quality 5

Traceback (most recent call last):
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimera/cmd_line/gui.py", line 121, in on_enter
cmd.execute()
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimera/core/commands/cli.py", line 1775, in execute
results.append(ci.function(session, **kw_args))
TypeError: save() got an unexpected keyword argument 'quality'

Change History (3)

comment:1 by Greg Couch, 10 years ago

Resolution: fixed
Status: newclosed

Fixed -- quality was left out of save command, but was in 'save image' command.

Also made is so the file suffix is added if missing (ie., the format is given).

comment:2 by Elaine Meng, 10 years ago

Re your earlier comment:


This is not working in the current daily build, for example "save image junk format j q 50” just makes a file named junk without suffix.

comment:3 by Tom Goddard, 10 years ago

The quality option works now, but the saving jpeg still fails due to bug #186, no jpeg support in Pillow.

Note: See TracTickets for help on using tickets.