Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#1906 closed defect (fixed)

H-bonds from mmCIF more dashes than H-bond display default

Reported by: Elaine Meng Owned by: pett
Priority: moderate Milestone:
Component: Depiction Version:
Keywords: Cc: Greg Couch
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

(e.g. 1bna and show it as atoms the H-bonds have more dashes than the default hbond display.

open 1bna
nuc atoms
...looks like 8 dashes
hb
...6 dashes are default

Change History (5)

comment:1 by Greg Couch, 6 years ago

The AtomicStructure class (in Python) has several H-bond attributes: default_hbond_color, default_hbond_radius, and default_hbond_dashes that are not given to the mmCIF created H-bond pseudobond group (in C++). Need to post-process the returned models. Maybe it should be part of auto-styling?

comment:2 by pett, 6 years ago

Cc: Greg Couch added; pett removed
Owner: changed from Greg Couch to pett

I think Greg is right -- it should happen in the Python atomic structure code so that any input-reader that creates hydrogen bonds gets the right look. I'll handle it.

comment:3 by pett, 6 years ago

Resolution: fixed
Status: assignedclosed

comment:4 by Elaine Meng, 6 years ago

did you change the hbonds default? Now it looks like hbonds makes dashes 8. I expected this fix to decrease the dashes shown from mmCIF to 6, rather than hbonds increasing to 8. But it's OK, just let me know if it was your intent and I'll change the hbond docs.

comment:5 by pett, 6 years ago

Seems that I did change the default to match the C++-level default -- which isn't really relevant. So I've changed them back to 6.

Note: See TracTickets for help on using tickets.