Opened 10 years ago

Closed 10 years ago

#188 closed defect (fixed)

Abbreviated command keyword matches wrong option

Reported by: Tom Goddard Owned by: Greg Couch
Priority: major Milestone:
Component: Command Line Version:
Keywords: Cc: meng@…
Blocked By: Blocking:
Notify when closed: Platform: all
Project: chimera

Description

I get that "sel sil true" matches "set silhouetteWidth true" (which gives an error). Elaine reports it matching "set silhouetteColor true". It should match "set silhouettes true" because keyword silhouettes is registered before the other keywords.

From: Elaine Meng
Subject: minor "set silhouettes" issue
Date: November 23, 2015 at 9:44:24 AM PST
To: Tom Goddard

Hi Tom,
I keep trying “set silhouette true” by mistake instead of “set silhouettes true”, and then ChimeraX complains because it thinks I was trying to set silhouetteColor. Isn’t a truncation supposed to match the shortest keyword? Or am I remembering incorrectly?
Thanks
Elaine

Change History (4)

comment:1 by Greg Couch, 10 years ago

Sorry guys, I can't reproduce this bug. It works as expected for me. 'set sil true' is correctly logged as 'set silhouettes true'.

-- Greg

comment:2 by Tom Goddard, 10 years ago

Aha, I just tried again and this time “set sil true” came out as "set silhouetteDepthJump true” (error).
Apparently it matches a random option with matching prefix. That explains why Elaine got silhouetteColor
and I previously got silhouetteWidth.

comment:3 by Elaine Meng, 10 years ago

It works occasionally. Then I start ChimeraX again and try it again and it doesn’t work. I just now tried “set silhouette 1” and the Log reported:

set silhouetteDepthJump 1

Then I quit and started again and tried “set silhouette true” and the Log reported:

set silhouetteColor true

…and complained that the value was invalid.
Elaine

comment:4 by Greg Couch, 10 years ago

Resolution: fixed
Status: newclosed

Fixed. Found the non-ordered dict and replaced it with an OrderedDict.

Note: See TracTickets for help on using tickets.