Opened 7 years ago

Closed 7 years ago

#1829 closed defect (fixed)

Views restored from sessions: self.positions key is None

Reported by: glander@… Owned by: Tom Goddard
Priority: normal Milestone: 0.9
Component: General Controls Version:
Keywords: Cc: greg
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

The following bug report has been submitted:
Platform:        Darwin-18.5.0-x86_64-i386-64bit
ChimeraX Version: 0.9 (2019-02-19)
Description
I can't seem to recover cxs files that have "views" saved

Log:
> camera ortho

> ui mousemode rightMode zoom

UCSF ChimeraX version: 0.9 (2019-02-19)  
© 2016-2019 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  

> open "/Users/glander/Dropbox (Scripps Research)/Manuscripts-InProg/Lon
Paper/ChimeraXSessions/cartoon-stepV2.cxs" format session

opened ChimeraX session  

> view one

Traceback (most recent call last):  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/cmd_line/tool.py", line 252, in execute  
cmd.run(cmd_text)  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/core/commands/cli.py", line 2617, in run  
result = ci.function(session, **kw_args)  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 53, in view  
show_view(session, objects, frames)  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 128, in show_view  
v2.remove_deleted_models()  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 194, in remove_deleted_models  
if m.deleted:  
AttributeError: 'NoneType' object has no attribute 'deleted'  
  
AttributeError: 'NoneType' object has no attribute 'deleted'  
  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 194, in remove_deleted_models  
if m.deleted:  
  
See log for complete Python traceback.  
  

> view two

Traceback (most recent call last):  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/cmd_line/tool.py", line 252, in execute  
cmd.run(cmd_text)  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/core/commands/cli.py", line 2617, in run  
result = ci.function(session, **kw_args)  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 53, in view  
show_view(session, objects, frames)  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 128, in show_view  
v2.remove_deleted_models()  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 194, in remove_deleted_models  
if m.deleted:  
AttributeError: 'NoneType' object has no attribute 'deleted'  
  
AttributeError: 'NoneType' object has no attribute 'deleted'  
  
File
"/Applications/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/std_commands/view.py", line 194, in remove_deleted_models  
if m.deleted:  
  
See log for complete Python traceback.  
  




OpenGL version: 4.1 INTEL-12.8.38
OpenGL renderer: Intel Iris OpenGL Engine
OpenGL vendor: Intel Inc.
File attachment: cartoon-stepV2.cxs

cartoon-stepV2.cxs

Attachments (1)

cartoon-stepV2.cxs (4.0 MB ) - added by glander@… 7 years ago.
Added by email2trac

Change History (3)

by glander@…, 7 years ago

Attachment: cartoon-stepV2.cxs added

Added by email2trac

comment:1 by Eric Pettersen, 7 years ago

Cc: greg added
Component: UnassignedGeneral Controls
Milestone: 0.9
Owner: set to Tom Goddard
Platform: all
Project: ChimeraX
Status: newassigned
Summary: ChimeraX bug report submissionViews restored from sessions: self.positions key is None

Reported by Gabe Lander

comment:2 by Tom Goddard, 7 years ago

Resolution: fixed
Status: assignedclosed

Fixed.

I believe this bug is caused by making a named view, then deleting a model used in that named view, then saving a session. I've fixed the code to ignore the deleted model in the view when restoring the session. A closed model is removed from the view in current ChimeraX, but older ChimeraX may not have properly removed.

In the attached session "view one" will work in tonight's ChimeraX build.

Note: See TracTickets for help on using tickets.