Opened 7 years ago
Closed 6 years ago
#1707 closed enhancement (fixed)
Set atom types for residue based on dictionary
| Reported by: | Tristan Croll | Owned by: | Eric Pettersen |
|---|---|---|---|
| Priority: | moderate | Milestone: | |
| Component: | Structure Editing | Version: | |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Notify when closed: | Platform: | all | |
| Project: | ChimeraX |
Description
AddH is getting things wrong for the modified nucleobase 1MG in 6hrm (partially because the starting geometry is a little wonky):
- O6 is treated as single-bonded (actually double)
- the ribose is treated like an aromatic ring (to be fair, the geometry *is* somewhat too close to planar, and the chirality is wrong at O2')
In cases like this, it would be great to have the option to add hydrogens strictly according to the CCD definition of the residue.
Change History (7)
follow-up: 2 comment:2 by , 7 years ago
Belay that. 7MG isn't wrong, the authors just chose the wrong residue ID (should be MG7). On 2019-02-14 12:15, ChimeraX wrote:
comment:3 by , 7 years ago
| Priority: | moderate → minor |
|---|---|
| Status: | assigned → accepted |
With the base-pairing flipped like that, there is no hydrogen bonding stabilizing the keto form of the guanine, so it may well favor the enol form. I wouldn't classify adding the proton there as "wrong". The C→O bond length is indicative of a single bond.
Looking the "sugar" ring, man, I can see why it got treated as furan. No impartial observer would think those carbons are tetrahedral.
I disfavor using CCD templates for protonation since they use neutral protonation states rather than biologically relevant (pH 7.4) protonation states. The typical remedy here is to explicitly assign the correct IDATM types to the ring atoms before protonation. Nonetheless I could allow using CCD templates as an option. I've added it to my low-priority to-do list.
--Eric
follow-up: 4 comment:4 by , 7 years ago
From my perspective, the most important thing is to first get *something* consistent with the force field so I can improve the geometry and fit to the map. Protonation states are a secondary issue for me - important, yes, but can only be predicted accurately *after* the geometry’s right. Tristan Croll Research Fellow Cambridge Institute for Medical Research University of Cambridge CB2 0XY
comment:5 by , 7 years ago
| Priority: | minor → moderate |
|---|---|
| Summary: | AddH: option to set hydrogens for residue based on dictionary → Set atom types for residue based on dictionary |
What you really want is a tool that sets the atom types based on templates as much as possible, which AddH will then naturally use with no changes. Do you agree?
comment:7 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | accepted → closed |
Not fixed as per my suggestion (setting atom types based on templating), but nonetheless addressed by the addh "template" keyword option.