Command history problems

[olibclarke@…]

The following bug report has been submitted:
Platform:        Darwin-18.2.0-x86_64-i386-64bit
ChimeraX Version: 0.9 (2019-01-26)
Description
The behavior of filtering the command history seems to be a bit inconsistent. The way it works in Chimera, and I believe the way it is intended to work in ChimeraX, is that Shift-up filters the command history by the typed characters. This seems to work fine when I first load up ChimeraX, then after some time it no longer works - it ignores what is already typed and doesn't use it to filter.

Additionally, both in Chimera and ChimeraX, it would be good if the command history position always "reset" to the most recent command when the command line text was cleared.

What I mean by that is, if I go back 100 commands using Shift-up, and delete that text, then press the up arrow, chimera (and chimerax) will retrieve command 101 in the history, rather than the most recent command - it only resets once I enter a new command.

Cheers
Oli

Log:
> camera ortho

> cofr centerOfView

> lighting soft

> lighting depthCueColor white

UCSF ChimeraX version: 0.9 (2019-01-26)  
© 2016-2019 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  

> open 1bl8 format mmCIF fromDatabase pdb

1bl8 title:  
Potassium channel (KCSA) from streptomyces lividans [more info...]  
  
Chain information for 1bl8 #1  
---  
Chain | Description  
A B C D | protein (potassium channel protein)  
  
  

> ~ribbon

> display

> ~display ~@CA

> cofr centerOfView showPivot true

> cofr frontCenter

> cofr centerOfView showPivot true

> clip near -10 far 10

> close all

> open
/Users/olibclarke/Dropbox/Downloads/cryosparc_P27_J326_005_volume_map_sharp.mrc

Opened cryosparc_P27_J326_005_volume_map_sharp.mrc, grid size 360,360,360,
pixel 1.06, shown at level 0.344, step 2, values float32  




OpenGL version: 4.1 INTEL-12.4.7
OpenGL renderer: Intel(R) Iris(TM) Graphics 6100
OpenGL vendor: Intel Inc.

[Eric Pettersen]

Well, mostly fixed. The ChimeraX command-search code had suffered significant "bit rot" and needed fixing. I made it so that editing the text resets the search position back to the start of the history list. There seems to be a bug in Qt in that using the line-kill character (control-U for me) to clear the line doesn't fire the "text edited" signal, so my code that resets the search history isn't called until you type another character of some sort (other than up/down arrow of course), so in that particular case searching will continue from the previous position. If you clear the line by other means (lots of Delete presses; select-all then Delete) the signal is fired and the history search position is reset.

I added the same search-reset code to regular Chimera, but its line-clear behavior is even worse in that not only does line-kill not trigger the "edited" signal, neither does select-all + Delete!

[olibclarke@…]

Great, sounds much improved!

Cheers
Oli