bundleinfo.xml tag for compiling executables

[Eric Pettersen]

Analogous to the CModule tag, I would like a CExecutable flag (or some such) for compiling executables from simple C or C++ sources. This would be used to compile AL2CO.

[Conrad Huang]

It's more analogous to CLibrary and it should be available in the daily builds tomorrow. src/bundles/test contains an example. Let me know of any problems.

[Eric Pettersen]

I tried to add a compile argument with:

<CompileArgument platform="mac">-Wno-logical-op-parentheses</CompileArgument>

but it didn't seem to "take"; the warnings that should have been suppressed weren't...

[Eric Pettersen]

In a related issue, for a package compiling an executable, should bundle_info.xml set purePython to false? The test bundle doesn't...

[Conrad Huang]

Did "-Wno-logical-op-parentheses" show up in the compile line when building the bundle?

You should not need to set the purePython flag because bundle_builder knows that bundles with CModule, CLibrary or CExecutable tags are automatically "impure".

[Conrad Huang]

The code has been changed to use the C++ linker if there are .cpp source files, so you should no longer need the "-lstdc++" lines.

[Eric Pettersen]

I do not see the flag in the generated compile line. In addition there is a new error:

Executing: devel install . user false exit true
C compiler: clang -pipe -I/Users/pett/src/chimerax/build/include -L/Users/pett/src/chimerax/build/lib -DUSE_DYLD_GLOBAL_NAMESPACE -fno-strict-aliasing -Wsign-compare -Wunreachable-code -fno-common -dynamic -F/Users/pett/src/chimerax/build/Library/Frameworks -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes

compile options: '-DDYNAMIC_LIBRARY=1 -I/Users/pett/src/chimerax/src/bundles/alignment_hdrs/../../../ChimeraX.app/Contents/include -I/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/include/python3.6m -c'
clang: al2co/al2co.c
clang: warning: argument unused during compilation: '-L/Users/pett/src/chimerax/build/lib' [-Wunused-command-line-argument]

al2co/al2co.c:568:18: warning: '&&' within 'else if (flag==3 && c==' '

' [-Wlogical-op-parentheses]

flag==3 && c=='\n'){

al2co/al2co.c:568:18: note: place parentheses around the '&&' expression to silence this warning

else if (flag==3 && c==' '

flag==3 && c=='\n'){

( )

al2co/al2co.c:568:39: warning: '&&' within 'else if (flag==3 && c==' '

' [-Wlogical-op-parentheses]

flag==3 && c=='\n'){

^~

al2co/al2co.c:568:39: note: place parentheses around the '&&' expression to silence this warning

else if (flag==3 && c==' '

flag==3 && c=='\n'){

( )

2 warnings generated.
Traceback (most recent call last):

File "/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/core/commands/devel.py", line 151, in _run

unbound_method(bb, *args, kw)

File "/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/bundle_builder/bundle_builder.py", line 85, in make_install

self.make_wheel(test=test, debug=debug)

File "/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/bundle_builder/bundle_builder.py", line 71, in make_wheel

executable.compile(self.logger, self.dependencies, debug=debug)

File "/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/bundle_builder/bundle_builder.py", line 889, in compile

target_lang=self.target_lang,

AttributeError: '_CExecutable' object has no attribute 'target_lang'

[Conrad Huang]

Can you please pull (bundle_builder.py) and try again?

target_lang was not initialized and did not work for non-C++ (i.e., C) code.

CompileArgument was only used to build Python extensions and not libraries or executables.

Both fixed and changes committed.

[Eric Pettersen]

It worked!