Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#14702 closed enhancement (fixed)

Atomic bundle cython code deprecation warning about "IF" statement

Reported by: Tom Goddard Owned by: Eric Pettersen
Priority: moderate Milestone:
Component: Core Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

Our updated Cython is giving a deprecation warning about the IF statement in our atomic_cpp/cymol.pyx file.

$ cd bundles/src/atomic
$ make install
PYTHONNOUSERSITE=1 ../../../ChimeraX.app/Contents/bin/python3.11 -I -m chimerax.core --nogui --exit --safemode --cmd "devel install . user false exit true "
Executing: devel install . user false exit true
Compiling atomic_cpp/cymol.pyx because it changed.
[1/1] Cythonizing atomic_cpp/cymol.pyx
warning: atomic_cpp/cymol.pyx:36:0: The 'IF' statement is deprecated and will be removed in a future Cython version. Consider using runtime conditions or C macros instead. See ​https://github.com/cython/cython/issues/4310

Change History (2)

comment:1 by Eric Pettersen, 20 months ago

Resolution: → fixed
Status: assigned → closed

Fix: ​https://github.com/RBVI/ChimeraX/commit/9cc7c5e6446dfc9f4c8f798beb6452d121e946ad

Though need to see if tonight's builds actually work on Windows.

comment:2 by Eric Pettersen, 20 months ago

Applied a different fix today, which seems to both compile _and_ run.

Note: See TracTickets for help on using tickets.