Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#1388 closed enhancement (fixed)

RFE: start/end for atomspec numerical ranges (or asterisk to mean them)

Reported by: Elaine Meng Owned by: Conrad Huang
Priority: moderate Milestone: 1.0
Component: Command Line Version:
Keywords: Cc: chimera-programmers
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

For command-line atomspecs, would be great if the words "start" and "end" and/or asterisk before or after hyphen could mean the first and last number available in the structure. Generally this is used only for residue numbers.

Chimera uses the words, not asterisks. I'd be happy with whichever is simpler to implement. If words, I lean towards using the same words as Chimera, but I'm not militant if you really prefer something else like "first" and "last".

Change History (9)

comment:1 by Conrad Huang, 7 years ago

Added support for "start" and "end" in residue ranges. Model ranges not implemented yet.

in reply to:  2 ; comment:2 by Elaine Meng, 7 years ago

Tests suggest “start” is working, but something wonky is going on with “end”… seems to get a bunch of extra residues:

open 1gcn
color :15-end purple
close

open 2gbp
label :150
color :150-end purple

comment:3 by Conrad Huang, 7 years ago

Resolution: fixed
Status: assignedclosed

Fixed in 8d2acd142.

Code was using residue atomspec as both type AND number+insert code. So residues that are alphabetically between "150" and "end" were selected as well. Now the type test is only used if the residue atomspec does NOT look like number+insert code.

in reply to:  4 ; comment:4 by Elaine Meng, 7 years ago

Still not implemented for model numbers, e.g.

open 1g1p
select #1.10-end

comment:5 by Elaine Meng, 7 years ago

Milestone: 1.0
Resolution: fixed
Status: closedreopened

comment:6 by Conrad Huang, 7 years ago

Resolution: fixed
Status: reopenedclosed

Fixed in 987564593.

Looks like "*" used to work. Fixed to use only "start" and "end" to match residue range syntax.

in reply to:  7 ; comment:7 by Elaine Meng, 7 years ago

I’m hoping * would still work to signify all (not start and end) as in the last wildcard example,   #*.1-3

http://rbvi.ucsf.edu/chimerax/docs/user/commands/atomspec.html#wildcards

If not, I suppose the workaround is  #start-end.1-3
 

comment:8 by Conrad Huang, 7 years ago

I first made the change to allow '*' as a model number wildcard, but the error message was really confusing when I tried #1.4-*. So I made '*' acceptable as either "start" or "end" as well. Now all these work:

color #start-end.start-3 red
color #*.start-3 red
color #*.*-3 red
color #*.4-end red
color #*.4-* red
color #*.1-3 red

comment:9 by Elaine Meng, 7 years ago

Looks good -- seems OK to close this ticket.

Note: See TracTickets for help on using tickets.