Session restore of color name: tuple indices must be integers or slices, not str

[Elaine Meng]

The following bug report has been submitted:
Platform:        Darwin-17.7.0-x86_64-i386-64bit
ChimeraX Version: 0.8 (2018-09-15)
Description
cannot restore session with custom color name

I opened some structure (doesn't matter, may not even need any structure) and defined a new color, e.g. command:

color name blorg 80,80,50

... then saved session.  Trying to restore session gives the traceback in the Log.

Log:
UCSF ChimeraX version: 0.8 (2018-09-15)  
How to cite UCSF ChimeraX  

open /Users/meng/Desktop/blorg.cxs format session ↵

Summary of feedback from opening /Users/meng/Desktop/blorg.cxs  
---  
error | Unable to restore session, resetting.  
  
Traceback (most recent call last):  
File
"/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-
packages/chimerax/core/session.py", line 584, in restore  
obj = sm.restore_snapshot(self, data)  
File
"/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-
packages/chimerax/core/colors.py", line 178, in restore_snapshot  
return Color(data['rgba'], limit=False)  
TypeError: tuple indices must be integers or slices, not str  
  
opened ChimeraX session  

toolshed show "Bug Reporter"




OpenGL version: 4.1 INTEL-10.36.19
OpenGL renderer: Intel Iris Pro OpenGL Engine
OpenGL vendor: Intel Inc.

[Eric Pettersen]

take_snapshot returns (version, dict); restoe_snapshot treats that tuple as a dictionary

[Tom Goddard]

Fixed.

Named color session save added by Greg saved the data as a tuple instead of a dictionary and later restore code changes assumed it was a dictionary since almost all session code saves data in dictionaries.

[Tom Goddard]

Sessions saved with named colors before today's fix will still give an error. If older sessions need to be restored I can improve the code to handle the older sessions with named colors.

[Elaine Meng]

I personally don’t need to restore older sessions with named colors.  I only found this bug by specifically testing whether custom colors were included in sessions, so unless other users protest, I’d say it’s not important to go the extra mile.