Opened 7 years ago

Closed 7 years ago

#1273 closed defect (fixed)

More accurately name Drawing highlighting API

Reported by: pett Owned by: Tom Goddard
Priority: blocker Milestone: 1.0
Component: Graphics Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

The Drawing API uses the term 'selected' when it really means 'highlighted', which leads to confusion in the Model API when trying to determine if a model is selected since if no highlighting is drawn (e.g. model hidden) then the Drawing API reports that 'selected' is False regardless of the selection state of items within the model.

The proposal is to change from using the term 'selected' to the term 'highlighted' in the Drawing API. When this happens, then a generic 'any_part_selected' call will need to be implemented in the Model class (probably returning False) which will be overridden as appropriate in subclasses.

Change History (2)

comment:1 by Tom Goddard, 7 years ago

Renamed graphics selection methods and properties to highlighting.

The graphics highlighting APIs are well established, but the higher level selection methods and properties of Model need more consideration to arrive at stable APIs.

comment:2 by Tom Goddard, 7 years ago

Resolution: → fixed
Status: assigned → closed
Note: See TracTickets for help on using tickets.