"name delete all" gives traceback: 'is_selector_reserved' is not defined

[Elaine Meng]

"name delete all" deletes built-in targets, whereas it should just delete any user-defined targets.

E.g.
open 2gbp
sel ligand
... OK so far ...
name delete all
sel ligand

Log:
select ligand
Expected an objects specifier or a keyword

[Elaine Meng]

I was going to close this but when I tried testing it in the newest daily available to me (mac... maybe it's fixed in newer builds available for other platforms) I got another problem.

UCSF ChimeraX version: 0.7 (2018-04-21)

open 2gbp
name del all

Traceback (most recent call last):

File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/cmd_line/tool.py", line 205, in execute

cmd.run(cmd_text)

File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/core/commands/cli.py", line 2622, in run

result = ci.function(session, kw_args)

File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/target/cmd.py", line 67, in name_delete

if not is_selector_reserved(name):

NameError: name 'is_selector_reserved' is not defined

NameError: name 'is_selector_reserved' is not defined

File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/target/cmd.py", line 67, in name_delete
if not is_selector_reserved(name):

[Conrad Huang]

Ack. Changed function from is_selector_reserved to is_selector_user_defined and then missed a call. Fixed in tomorrow's build.

[Elaine Meng]

now gives a different traceback!

UCSF ChimeraX version: 0.7 (2018-05-04)

name delete all
Traceback (most recent call last):

File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/cmd_line/tool.py", line 205, in execute

cmd.run(cmd_text)

File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/core/commands/cli.py", line 2633, in run

result = ci.function(session, kw_args)

File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/target/cmd.py", line 67, in name_delete

if is_selector_user_defined(name):

NameError: name 'is_selector_user_defined' is not defined

NameError: name 'is_selector_user_defined' is not defined

File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/target/cmd.py", line 67, in name_delete
if is_selector_user_defined(name):

[Conrad Huang]

I must have committed changes in the middle of fixing "Targets" bundle because I thought had finished. Well, it's really finished now (he says with his fingers crossed). The bundle name has been changed (from "Targets" to "BasicActions") and all the file and variable names that referred to "target" now reference "name". Should be in tomorrow's build. (Leaving ticket open until then.)

[Elaine Meng]

Ran a couple tests, "name delete all" seems to be working as advertised.