Opened 8 years ago

Closed 8 years ago

#1038 closed defect (fixed)

Atom DrawMode Python values out of sync with C++ enum

Reported by: Tristan Croll Owned by: Eric Pettersen
Priority: major Milestone:
Component: Depiction Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

in C++:
enum class DrawMode: unsigned char { Sphere, EndCap, Ball };

in Python:

from chimerax.core.atomic import Atom
Atom.SPHERE_STYLE
  0
Atom.STICK_STYLE
  2
Atom.BALL_STYLE
  1

... so I think EndCap and Ball need to be switched for consistency?

Change History (2)

comment:1 by Tom Goddard, 8 years ago

Owner: changed from Tom Goddard to Eric Pettersen

Yes the C++ and Python Ball and EndCap atom draw-modes are swapped relative to one another. I guess this never mattered because none of the C++ code uses those enumeration values. I'll let Eric decide which one to change so they agree.

comment:2 by Eric Pettersen, 8 years ago

Resolution: → fixed
Status: assigned → closed

Good catch. I have changed the C++ to match Python.

Note: See TracTickets for help on using tickets.