Opened 2 years ago

Closed 14 months ago

#10035 closed enhancement (fixed)

Add tests to DICOM

Reported by: Zach Pearson Owned by: Zach Pearson
Priority: high Milestone:
Component: DICOM Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

I had to revert two commits recently that fixed some TCIA datasets so that I could get the 4D Lung dataset to load. It would be nice to add tests to the DICOM bundle so that I can make changes to e.g. slice sorting or large refactors without fear of breaking other datasets. As the complexity of the bundle grows so does the importance of this ticket.

Change History (2)

comment:1 by Zach Pearson, 18 months ago

Milestone: 1.8

This needn't be milestoned.

comment:2 by Zach Pearson, 14 months ago

Resolution: → fixed
Status: assigned → closed

Added tests for opening DICOM files in ​this commit. Test data needs to be downloaded from Plato to dicom/tests/data or the test will be skipped.

Note: See TracTickets for help on using tickets.