Changes between Initial Version and Version 1 of Ticket #8474, comment 5


Ignore:
Timestamp:
Feb 14, 2023, 9:38:17 AM (3 years ago)
Author:
Eric Pettersen

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #8474, comment 5

    initial v1  
    1 The PseudobondGroup constructor for structure-associated groups adds the group to the structure submodels, which in turn fires the ADD_MODELS trigger (if the structure is open).  So, depending on what the handlers for that trigger are doing, this could result in a loop of the C++ layer trying to create Python instances.  Now, the ADD_MODELS trigger is suppressed until the C++ call finishes.  I'm not 1000% convinced that this was the problem here, but am nonetheless closing this ticket until the problem is reported again -- which is hopefully never. :-)
     1The !PseudobondGroup constructor for structure-associated groups adds the group to the structure submodels, which in turn fires the ADD_MODELS trigger (if the structure is open).  So, depending on what the handlers for that trigger are doing, this could result in a loop of the C++ layer trying to create Python instances.  Now, the ADD_MODELS trigger is suppressed until the C++ call finishes.  I'm not 1000% convinced that this was the problem here, but am nonetheless closing this ticket until the problem is reported again -- which is hopefully never. :-)
    22
    33Fix: https://github.com/RBVI/ChimeraX/commit/83420b0902619bed5fb0efd96c2c7ca4e8672960