Changes between Initial Version and Version 1 of Ticket #5527, comment 2


Ignore:
Timestamp:
Nov 3, 2021, 12:04:43 PM (4 years ago)
Author:
pett

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #5527, comment 2

    initial v1  
    11I tested out having the structure live on with zero atoms and immediately got a segmentation fault, and I'm pretty sure that was the tip of a very large iceberg -- so I went the other route and had deleting all atoms call Structure.delete() rather than directly calling the C++ destructor.
    22
    3 Fixed by [https://github.com/RBVI/ChimeraX/commit/1b8148798e8ae18f4fa6951c398634bea3a396c7 this commit].
     3Fixed by [https://github.com/RBVI/ChimeraX/commit/ec903ad03031e32e4920a1946ce9ce499ef539f9 this commit].
    44
    55I only put it on the develop branch.  If you felt it was a good/safe idea I could put it on the release branch as well.